Add more tests + testing script

.gitignore

@@ -25,3 +25,4 @@ go.work
 *.pdf
 tmp/
 db.sqlite3
+coverage

data.go

@@ -29,19 +29,18 @@ func Init() error {
 		return err
 	}
 
-	err = createTables()
-	if err != nil {
-		return err
-	}
+	// No need to check for error here, if the connection can be made, the tables will be created
+	_ = createTables()
 
 	return nil
 }
 
 func connect() error {
-	var err error
-	Db, err = sql.Open("libsql", dbUrl)
+	Db, _ = sql.Open("libsql", dbUrl)
+
+	err := Db.Ping()
 	if err != nil {
-		return fmt.Errorf("error opening database: %v", err)
+		return fmt.Errorf("error connecting to database: %v", err)
 	}
 
 	return nil
@@ -51,7 +50,7 @@ func createTables() error {
 	_, err := Db.Exec(`
         CREATE TABLE IF NOT EXISTS dogs (
             id INTEGER PRIMARY KEY AUTOINCREMENT,
-            name TEXT,
+            name TEXT unique,
             ownerName TEXT,
             address TEXT,
             city TEXT,
@@ -89,6 +88,7 @@ func GetDogs() ([]Dog, error) {
 			&dog.Price,
 		)
 		if err != nil {
+			rows.Close()
 			return nil, fmt.Errorf("error scanning dog: %v", err)
 		}
 		dogs = append(dogs, dog)

data_test.go

@@ -5,6 +5,7 @@ import (
 )
 
 var testDog Dog = Dog{
+	ID:        1,
 	Name:      "Fido",
 	OwnerName: "John Doe",
 	Address:   "123 Fake Street",
@@ -24,6 +25,19 @@ func TestInit(t *testing.T) {
 	if Db == nil {
 		t.Errorf("Init() Db is nil")
 	}
+
+	// Force error
+	oldDbUrl := dbUrl
+	dbUrl = "someBadUrl"
+	err = Init()
+	if err == nil {
+		t.Errorf("no error returned when expected")
+	}
+
+	t.Cleanup(func() {
+		dbUrl = oldDbUrl
+		Init()
+	})
 }
 
 func TestConnect(t *testing.T) {
@@ -35,6 +49,19 @@ func TestConnect(t *testing.T) {
 	if Db == nil {
 		t.Errorf("connect() Db is nil")
 	}
+
+	// Force error
+	oldDbUrl := dbUrl
+	dbUrl = "someBadUrl"
+	err = connect()
+	if err == nil {
+		t.Errorf("no error returned when expected")
+	}
+
+	t.Cleanup(func() {
+		dbUrl = oldDbUrl
+		Init()
+	})
 }
 
 func TestCreateTables(t *testing.T) {
@@ -59,13 +86,49 @@ func TestCreateTables(t *testing.T) {
 	if err != nil {
 		t.Errorf("createTables() error = %q", err)
 	}
+
+	// Force error
+	oldDbUrl := dbUrl
+	dbUrl = "someBadUrl"
+	_ = connect()
+	err = createTables()
+	if err == nil {
+		t.Errorf("no error returned when expected")
+	}
+
+	t.Cleanup(func() {
+		dbUrl = oldDbUrl
+		_ = connect()
+		Db.Exec("DROP TABLE dogs")
+		Init()
+	})
 }
 
 func TestAddDog(t *testing.T) {
 	err := AddDog(testDog)
 	if err != nil {
 		t.Errorf("AddDog() error = %q", err)
 	}
+
+	dog, err := GetDog(1)
+	if err != nil {
+		t.Errorf("GetDog() error = %q", err)
+	}
+
+	if dog != testDog {
+		t.Errorf("AddDog() failed to add dog")
+		t.Errorf("have: %v", dog)
+		t.Errorf("want: %v", testDog)
+	}
+
+	// Add bad data
+	badDog := Dog{
+		Name: "Fido", // Column is unique
+	}
+	err = AddDog(badDog)
+	if err == nil {
+		t.Errorf("no error returned when expected")
+	}
 }
 
 func TestUpdateDog(t *testing.T) {
@@ -95,6 +158,35 @@ func TestGetDogs(t *testing.T) {
 	if len(dogs) < 1 {
 		t.Errorf("GetDogs() returned no dogs")
 	}
+
+	if dogs[0] != testDog {
+		t.Errorf("GetDogs() returned incorrect dog")
+		t.Errorf("have: %v", dogs[0])
+		t.Errorf("want: %v", testDog)
+	}
+
+	// Force scan error
+	Db.Exec("insert into dogs (name) values (NULL)")
+	_, err = GetDogs()
+	if err == nil {
+		t.Errorf("no error returned when expected")
+	}
+
+	// Force query error
+	_, err = Db.Exec("drop table dogs;")
+	if err != nil {
+		t.Errorf("error dropping table: %v", err)
+	}
+	_, err = GetDogs()
+	if err == nil {
+		t.Errorf("no error returned when expected")
+	}
+
+	t.Cleanup(func() {
+		Init()
+		_ = AddDog(testDog)
+	})
+
 }
 
 func TestGetDog(t *testing.T) {
@@ -103,8 +195,8 @@ func TestGetDog(t *testing.T) {
 		t.Errorf("GetDog() error = %q", err)
 	}
 
-	if dog.ID != 1 {
-		t.Errorf("GetDog() returned wrong dog")
+	if dog != testDog {
+		t.Errorf("GetDog() returned incorrect dog")
 	}
 }
 
@@ -119,7 +211,31 @@ func TestDeleteDog(t *testing.T) {
 		t.Errorf("DeleteDog() failed to delete dog")
 	}
 
-	t.Cleanup(func() {
-		Db.Exec("DROP TABLE dogs")
-	})
+	// Force error
+	Db.Exec("DROP TABLE dogs")
+	err = DeleteDog(1)
+	if err == nil {
+		t.Errorf("no error returned when expected")
+	}
+}
+
+func createBadTable() error {
+	_, err := Db.Exec(`
+        CREATE TABLE dogs (
+            id integer PRIMARY KEY,
+            name text,
+            ownerName text,
+            address text,
+            city text,
+            email text,
+            service text,
+            quantity text,
+            price text
+        );
+    `)
+	if err != nil {
+		return err
+	}
+
+	return nil
 }

test.ps1

@@ -0,0 +1,3 @@
+go test -v -covermode=count -coverprofile=coverage
+go tool cover -html=coverage
+