Move exampels to separate crate #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
changed the title
haerdib
force-pushed
the
bh/make-examples-crate
branch
from
367641e
to
a12946c
Compare
echevrier
reviewed
Dec 15, 2022
|
That sadly doesn't work because of cargo. To name the second example folder |
clangenb
approved these changes
Dec 15, 2022
Comment on lines
+16
to
+25
| frame-support = { git = "https://github.com/paritytech/substrate.git", branch = "master" } | ||
| frame-system = { git = "https://github.com/paritytech/substrate.git", branch = "master" } | ||
| kitchensink-runtime = { git = "https://github.com/paritytech/substrate.git", branch = "master" } | ||
| pallet-balances = { git = "https://github.com/paritytech/substrate.git", branch = "master" } | ||
| pallet-identity = { git = "https://github.com/paritytech/substrate.git", branch = "master" } | ||
| pallet-staking = { git = "https://github.com/paritytech/substrate.git", branch = "master" } | ||
| sp-core = { features = ["full_crypto"], git = "https://github.com/paritytech/substrate.git", branch = "master" } | ||
| sp-keyring = { git = "https://github.com/paritytech/substrate.git", branch = "master" } | ||
| sp-runtime = { git = "https://github.com/paritytech/substrate.git", branch = "master" } | ||
| sp-version = { git = "https://github.com/paritytech/substrate.git", branch = "master" } |
There was a problem hiding this comment.
I like that these deps no longer live in the root workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the examples don't need to inherit all the features of the api-client. They import the api-client with the necessary features. This serves as a better example on how to import and use the api-client.