Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add From implementation to ExtrinsicSigner #459

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Add From implementation to ExtrinsicSigner #459

merged 3 commits into from
Feb 13, 2023

Conversation

masapr
Copy link
Collaborator

@masapr masapr commented Feb 10, 2023

closes #452

@masapr masapr added F7-enhancement Enhances an already existing functionality E1-breaksnothing labels Feb 10, 2023
@masapr masapr requested a review from haerdib February 10, 2023 16:16
@masapr masapr self-assigned this Feb 10, 2023
haerdib
haerdib reviewed Feb 13, 2023
View reviewed changes
primitives/src/signer.rs Outdated Show resolved Hide resolved
@masapr masapr requested a review from haerdib February 13, 2023 08:44
@masapr masapr marked this pull request as ready for review February 13, 2023 08:44
haerdib
haerdib approved these changes Feb 13, 2023
View reviewed changes
primitives/Cargo.toml Outdated Show resolved Hide resolved
primitives/src/signer.rs Outdated Show resolved Hide resolved
@masapr masapr merged commit a80fdce into master Feb 13, 2023
@masapr masapr deleted the sp/extrinsic_signer_from branch February 13, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haerdib haerdib haerdib approved these changes

Assignees

@masapr masapr

Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impl From<sp_core::sr25519::Pair> for ExtrinsicSigner
2 participants
@masapr @haerdib