Clean up dependencies and fix primitives no_std build #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
changed the title
haerdib
changed the title
haerdib
changed the title
haerdib
added
F2-bug
haerdib
commented
Apr 13, 2023
| @@ -77,8 +77,7 @@ async fn main() { | |||
| let string_error = format!("{:?}", e); | |||
| // We expect a TokenError::FundsUnavailable error. See : | |||
| //https://github.com/paritytech/substrate/blob/b42a687c9050cbe04849c45b0c5ccadb82c84948/frame/support/src/traits/tokens/fungible/mod.rs#L177 | |||
| assert!(string_error.contains("Other")); | |||
| assert!(string_error.contains("[7, 0, 194, 110, 3, 65, 37, 56, 0, 0]")); //Fixme This is for now not decoded. See issue: #488 | |||
There was a problem hiding this comment.
This assert failed for some reason (different error seems to be returned now). However, since we cant decode this error anyway, I don't see much sense in asserting the error. Removed it.
There was a problem hiding this comment.
Totally agree with this reasoning.
Niederb
reviewed
Apr 14, 2023
| @@ -77,8 +77,7 @@ async fn main() { | |||
| let string_error = format!("{:?}", e); | |||
| // We expect a TokenError::FundsUnavailable error. See : | |||
| //https://github.com/paritytech/substrate/blob/b42a687c9050cbe04849c45b0c5ccadb82c84948/frame/support/src/traits/tokens/fungible/mod.rs#L177 | |||
| assert!(string_error.contains("Other")); | |||
| assert!(string_error.contains("[7, 0, 194, 110, 3, 65, 37, 56, 0, 0]")); //Fixme This is for now not decoded. See issue: #488 | |||
There was a problem hiding this comment.
Totally agree with this reasoning.
Niederb
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As preparatory steps for publishing on crates.io:
Clean up the toml files:
Additionally, found while cleaning dependencies:
Removed
assertin error example because it constantly failed (substrate upgrade?). But since there is no decoding anyway, I don't see the use case in checking the encoded error.Last, but not least: