Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async support for subscription #612

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Add async support for subscription #612

merged 3 commits into from
Jul 10, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Jul 10, 2023 •
edited
Loading

closes #549

@haerdib haerdib self-assigned this Jul 10, 2023
@haerdib haerdib marked this pull request as ready for review July 10, 2023 10:58
@haerdib haerdib requested a review from echevrier July 10, 2023 10:59
haerdib
haerdib commented Jul 10, 2023
View reviewed changes
examples/examples/event_error_details.rs
@@ -13,11 +13,9 @@
limitations under the License.
*/

use codec::Decode;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused imports

@haerdib haerdib requested a review from Niederb July 10, 2023 10:59
@haerdib haerdib changed the title Add async subscription Add async support for subscription Jul 10, 2023
echevrier
echevrier approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haerdib
Copy link
Contributor Author

haerdib commented Jul 10, 2023

@Niederb I'll merge for now. But I'd still be happy if you could have a look at it.

@haerdib haerdib merged commit d19c242 into master Jul 10, 2023
38 checks passed
@haerdib haerdib deleted the bh/async branch July 10, 2023 14:18
@Niederb
Copy link
Contributor

Niederb commented Jul 18, 2023

@Niederb I'll merge for now. But I'd still be happy if you could have a look at it.

@haerdib I had a quick look and it looks quite nice. Much more straightforward than I thought. I will try to implement #348 now. During that I will have a closer look.

@haerdib haerdib added F7-enhancement Enhances an already existing functionality F8-newfeature Introduces a new feature and removed F7-enhancement Enhances an already existing functionality labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echevrier echevrier echevrier approved these changes

@Niederb Niederb Awaiting requested review from Niederb

Assignees

@haerdib haerdib

Labels
E1-breaksnothing F8-newfeature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support async for subscriptions
3 participants
@haerdib @Niederb @echevrier