Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macros: Return optional extrinsic instead of unwrapping #709

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Macros: Return optional extrinsic instead of unwrapping #709

merged 7 commits into from
Feb 20, 2024

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Feb 6, 2024 •
edited
Loading

  • Updates the compose macros to return an Option instead of potentially unsafe unwrapping.
  • Changes description from module to more commonly used pallet.

closes #705

@haerdib haerdib self-assigned this Feb 6, 2024
@haerdib haerdib changed the title Remove unwraps from macros and add Option return value instead Return optional extrinsic instead of unwrapping Feb 6, 2024
@haerdib haerdib changed the title Return optional extrinsic instead of unwrapping Macros: Return optional extrinsic instead of unwrapping Feb 6, 2024
@haerdib haerdib added F1-security possible vulnerability E2-breaksapi labels Feb 7, 2024
@haerdib haerdib marked this pull request as ready for review February 19, 2024 10:29
@haerdib haerdib requested a review from masapr February 19, 2024 10:29
masapr
masapr approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@haerdib haerdib merged commit 763164c into master Feb 20, 2024
56 checks passed
@haerdib haerdib deleted the bh/clean-up-macros branch February 20, 2024 16:03
@haerdib haerdib mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masapr masapr masapr approved these changes

Assignees

@haerdib haerdib

Labels
E2-breaksapi F1-security possible vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsafe unwraps in macro: Remove or declare as unsafe
2 participants
@haerdib @masapr