Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified version and soversion between all supported build systems #565

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Unified version and soversion between all supported build systems #565

merged 1 commit into from
Jan 13, 2021

Conversation

xvitaly
Copy link
Contributor

@xvitaly xvitaly commented Jan 13, 2021

Unified version and soversion between all supported build systems.

Closes #564. Closes #561.

@xvitaly
Copy link
Contributor Author

xvitaly commented Jan 13, 2021

Now all build systems produces the same result.

Cmake:

$ ls -l
lrwxrwxrwx. 1 vitaly vitaly      15 Jan 13 14:01 libusrsctp.so -> libusrsctp.so.2
lrwxrwxrwx. 1 vitaly vitaly      19 Jan 13 14:01 libusrsctp.so.2 -> libusrsctp.so.2.0.0
-rwxrwxr-x. 1 vitaly vitaly 1801360 Jan 13 14:01 libusrsctp.so.2.0.0
$ objdump -p libusrsctp.so.2.0.0 | grep SONAME
  SONAME               libusrsctp.so.2

Meson:

$ ls -l
lrwxrwxrwx. 1 vitaly vitaly      15 Jan 13 14:02 libusrsctp.so -> libusrsctp.so.2
lrwxrwxrwx. 1 vitaly vitaly      19 Jan 13 14:02 libusrsctp.so.2 -> libusrsctp.so.2.0.0
-rwxrwxr-x. 1 vitaly vitaly 1731888 Jan 13 14:03 libusrsctp.so.2.0.0
$ objdump -p libusrsctp.so.2.0.0 | grep SONAME
  SONAME               libusrsctp.so.2

Automake:

$ ls -l
lrwxrwxrwx. 1 vitaly vitaly      19 Jan 13 14:04 libusrsctp.so -> libusrsctp.so.2.0.0
lrwxrwxrwx. 1 vitaly vitaly      19 Jan 13 14:04 libusrsctp.so.2 -> libusrsctp.so.2.0.0
-rwxr-xr-x. 1 vitaly vitaly 1798720 Jan 13 14:04 libusrsctp.so.2.0.0
$ objdump -p libusrsctp.so.2.0.0 | grep SONAME
  SONAME               libusrsctp.so.2

@tehnick
Copy link

tehnick commented Jan 13, 2021

LGTM

@jonassmedegaard
Copy link

Please beware that the version-info in usrsctplib/Makefile.am does not declare a SONAME but happens to resolve to a SONAME when never tracking revisions nor feature introductions, only ever tracking major breaking changes.
See https://autotools.io/libtool/version.html for the details.

@tuexen
Copy link
Member

tuexen commented Jan 13, 2021

@weinrank. @lgrahl OK?

@tuexen tuexen merged commit 07f871b into sctplab:master Jan 13, 2021
@tuexen
Copy link
Member

tuexen commented Jan 13, 2021

Thanks for the help!

@tuexen
Copy link
Member

tuexen commented Jan 13, 2021 via email

@xvitaly
Copy link
Contributor Author

xvitaly commented Jan 13, 2021

Done.

Thanks. Will update Fedora builds soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants