Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO for nullable string arrays #1558

Merged
merged 29 commits into from
Aug 30, 2024
Merged

IO for nullable string arrays #1558

merged 29 commits into from
Aug 30, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Jul 5, 2024

What to use as backend?

@flying-sheep flying-sheep changed the title Placeholder impl Implement nullable string dtype Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 98.73418% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (17222d4) to head (d8297a0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/_io/specs/methods.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1558      +/-   ##
==========================================
- Coverage   86.72%   84.38%   -2.34%     
==========================================
  Files          37       37              
  Lines        5982     6027      +45     
==========================================
- Hits         5188     5086     -102     
- Misses        794      941     +147     
Files with missing lines Coverage Δ
src/anndata/_io/zarr.py 83.54% <ø> (ø)
src/anndata/_settings.py 93.83% <100.00%> (+0.04%) ⬆️
src/anndata/tests/helpers.py 83.12% <100.00%> (-10.99%) ⬇️
src/anndata/_io/specs/methods.py 88.67% <96.77%> (+0.27%) ⬆️

... and 6 files with indirect coverage changes

@flying-sheep flying-sheep changed the title Implement nullable string dtype IO for nullable string arrays Jul 5, 2024
@flying-sheep flying-sheep marked this pull request as ready for review August 27, 2024 09:24
@flying-sheep flying-sheep added this to the 0.11.0 milestone Aug 27, 2024
Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we want this as opt-in? #679 (comment)

@flying-sheep
Copy link
Member Author

yup, you’re right, I should have requested a review after adding that part

src/anndata/_io/specs/methods.py Outdated Show resolved Hide resolved
src/anndata/_io/specs/methods.py Outdated Show resolved Hide resolved
src/anndata/_io/specs/methods.py Outdated Show resolved Hide resolved
src/anndata/_io/specs/methods.py Outdated Show resolved Hide resolved
src/anndata/tests/helpers.py Show resolved Hide resolved
@ivirshup ivirshup modified the milestones: 0.11.0, 0.12.0 Aug 29, 2024
src/anndata/_io/specs/methods.py Outdated Show resolved Hide resolved
src/anndata/_io/specs/methods.py Outdated Show resolved Hide resolved
src/anndata/_io/specs/methods.py Show resolved Hide resolved
src/anndata/_io/specs/methods.py Outdated Show resolved Hide resolved
src/testing/anndata/_pytest.py Show resolved Hide resolved
@flying-sheep flying-sheep merged commit 8f3299b into main Aug 30, 2024
15 checks passed
@flying-sheep flying-sheep deleted the string-dtype branch August 30, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullable string columns
3 participants