Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): minimum python version 3.11 forNamedTuple with Generic #1594

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Aug 12, 2024

I was off on the version in my old comment: python/cpython#92027

In any case, we can just use typing_extensions: python/typing_extensions#44 but I don't think it's worth it so we'll just correct the feature version for the check.

Previously, this was causing issues with 3.10 as this was the case not covered (this feature broke in 3.9, but is fixed in 3.11, and we special cased <3.10).

  • Closes #
  • Tests added
  • Release note added (or unnecessary)

@ilan-gold ilan-gold added this to the 0.11.0 milestone Aug 12, 2024
@ilan-gold ilan-gold enabled auto-merge (squash) August 12, 2024 20:04
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (e0b81f1) to head (cb42f98).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1594      +/-   ##
==========================================
- Coverage   86.70%   83.64%   -3.07%     
==========================================
  Files          37       37              
  Lines        5974     5950      -24     
==========================================
- Hits         5180     4977     -203     
- Misses        794      973     +179     
Files Coverage Δ
src/anndata/_settings.py 89.40% <100.00%> (-4.64%) ⬇️

... and 14 files with indirect coverage changes

@ilan-gold ilan-gold merged commit 9f8b5ba into main Aug 12, 2024
21 of 22 checks passed
@ilan-gold ilan-gold deleted the ig/fix_namedtuple_310 branch August 12, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant