-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize Nones #999
base: main
Are you sure you want to change the base?
Serialize Nones #999
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
- Coverage 85.03% 82.90% -2.13%
==========================================
Files 36 36
Lines 5385 5394 +9
==========================================
- Hits 4579 4472 -107
- Misses 806 922 +116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As discussed, I don't want to change the on-disk format in the next release. So I'd hold off on this until at least 0.11. |
Since 0.10 is released, we can document and then merge this, right? |
I would like to have proposals for all disk format changes written up and discussed with other implementers before merging them to main. |
Sure, we can use this PR as reference implementation. Which other implementers are there? Is there a channel with the relevant people on some communication medium? |
.write
does not saveNone
values #673Rendered release notes