Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize Nones #999

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Serialize Nones #999

wants to merge 12 commits into from

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Jun 7, 2023

Rendered release notes

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #999 (c9fede4) into main (8ffe21e) will decrease coverage by 2.13%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
- Coverage   85.03%   82.90%   -2.13%     
==========================================
  Files          36       36              
  Lines        5385     5394       +9     
==========================================
- Hits         4579     4472     -107     
- Misses        806      922     +116     
Flag Coverage Δ
gpu-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
anndata/_io/specs/methods.py 88.05% <100.00%> (+0.07%) ⬆️
anndata/_io/specs/registry.py 95.62% <ø> (-0.06%) ⬇️

... and 7 files with indirect coverage changes

@flying-sheep flying-sheep changed the title Save Nones Serialize Nones Jun 7, 2023
@flying-sheep flying-sheep marked this pull request as ready for review June 7, 2023 13:23
@ivirshup
Copy link
Member

As discussed, I don't want to change the on-disk format in the next release. So I'd hold off on this until at least 0.11.

@flying-sheep flying-sheep modified the milestones: 0.10.0, 0.11.0 Jul 10, 2023
@flying-sheep
Copy link
Member Author

Since 0.10 is released, we can document and then merge this, right?

@ivirshup
Copy link
Member

ivirshup commented Oct 6, 2023

I would like to have proposals for all disk format changes written up and discussed with other implementers before merging them to main.

@flying-sheep
Copy link
Member Author

Sure, we can use this PR as reference implementation.

Which other implementers are there? Is there a channel with the relevant people on some communication medium?

@ivirshup ivirshup modified the milestones: 0.11.0, 0.12.0 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.write does not save None values
2 participants