Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n_components parameter for sc.tl.tsne #2671

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TarikExner
Copy link

Dear scanpy-team,

thank you very much for this great package!

Similar to issues https://github.com/scverse/scanpy/issues/1435 and https://github.com/scverse/scanpy/issues/460 I am interested in having an n_components parameter in the sc.tl.tsne function.

Apparently, the commit was made but no pull request was opened back in 2019.

I added the necessary parameter to the arguments and passed them via the params_sklearn dict to the respective function.

Documentation is also updated.

If you feel there is a need for a separate test, let me know, happy to include one.

Best,
Tarik

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2671 (3abf5c2) into master (0d4c6d2) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2671   +/-   ##
=======================================
  Coverage   72.16%   72.16%           
=======================================
  Files         108      108           
  Lines       11908    11908           
=======================================
+ Hits         8593     8594    +1     
+ Misses       3315     3314    -1     
Files Changed Coverage Δ
scanpy/tools/_tsne.py 90.00% <ø> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant