-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs. vs. obs for all grouped plots using BasePlot
#2769
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
- Coverage 75.24% 75.12% -0.13%
==========================================
Files 116 116
Lines 12802 12847 +45
==========================================
+ Hits 9633 9651 +18
- Misses 3169 3196 +27
|
# _matrix.columns = [f"{x}_{idx}" for idx, x in enumerate(_matrix.columns)] # added warning as this row was commented out | ||
if _matrix.columns.value_counts().max() > 1: | ||
warn( | ||
"Duplicate gene or condition labels present." | ||
"Results might be unexpected." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yugeji commenting this out doesn’t work with newer pandas versions anymore. Does your branch handle duplicated columns? Then we can just move this into the if len(self.groupby_cols) < 1:
branch
groupby_cols
params