Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parquet support for visium HD #2992

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ktpolanski
Copy link
Contributor

  • Release notes not necessary because:

Visium HD stores its coordinates in a .parquet file. This loads said file.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.49%. Comparing base (9c8c095) to head (8e23732).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
- Coverage   75.51%   75.49%   -0.02%     
==========================================
  Files         117      117              
  Lines       12955    12959       +4     
==========================================
+ Hits         9783     9784       +1     
- Misses       3172     3175       +3     
Files Coverage Δ
scanpy/readwrite.py 67.72% <40.00%> (-0.43%) ⬇️

@Rafael-Silva-Oliveira
Copy link

Also refer to #2982

@ktpolanski
Copy link
Contributor Author

We ran some data through spaceranger 3.0.1 locally, and in doing so found that 10X have reduced redundancy in the spatial folder of the binned outputs by moving the tissue images to a new, central location. This understandably breaks the existing loader.

A hotfix is to copy the images back into the appropriate subdirectory, but that's not a feasible expectation on users. I added an optional argument spaceranger_image_path to point to the new folder if need be, which should hopefully be robust with regard to any sort of further restructuring 10X may choose to do in the future.

The code is currently included in bin2cell in case anybody needs it or just wants to take it out for a spin, but I think it belongs in a more central location.

@giovp
Copy link
Member

giovp commented Sep 5, 2024

hi @ktpolanski ,thank you for the heads up

A hotfix is to copy the images back into the appropriate subdirectory, but that's not a feasible expectation on users. I added an optional argument spaceranger_image_path to point to the new folder if need be, which should hopefully be robust with regard to any sort of further restructuring 10X may choose to do in the future.

The code is currently included in bin2cell in case anybody needs it or just wants to take it out for a spin, but I think it belongs in a more central location.

@LucaMarconato do we have any datasets that test for spaceranger 3.0.1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for Visium HD Spatial Gene Expression data
3 participants