Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrublet reproducer #3069

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add scrublet reproducer #3069

wants to merge 12 commits into from

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented May 17, 2024

  • Release notes not necessary because:

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.63%. Comparing base (c6766d7) to head (19989bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3069   +/-   ##
=======================================
  Coverage   76.63%   76.63%           
=======================================
  Files         109      109           
  Lines       12533    12533           
=======================================
  Hits         9605     9605           
  Misses       2928     2928           

@flying-sheep flying-sheep added this to the 1.10.3 milestone Jun 27, 2024
@flying-sheep
Copy link
Member

hmm, we could just make the upload conditional to the file existing and merge this into main. Then we can debug things as soon as the problem occurs somewhere, and finally undo this PR when commiting the actual fix

@ilan-gold
Copy link
Contributor Author

TODO: creation of zarr store conditional on failed test, and then do the upload conditional on file existence

@flying-sheep flying-sheep changed the title Ig/fix scrublet Add scrublet reproducer Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Scrublet Test
2 participants