Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingest example. Fixes AttributeError: 'Ingest' object has no attribute '_pca_use_hvg' #3075

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

siebrenf
Copy link

  • Release notes not necessary because: trivial change

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.86%. Comparing base (a20334f) to head (3a84581).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3075   +/-   ##
=======================================
  Coverage   75.86%   75.86%           
=======================================
  Files         110      110           
  Lines       12531    12531           
=======================================
  Hits         9507     9507           
  Misses       3024     3024           
Files Coverage Δ
scanpy/tools/_ingest.py 77.33% <ø> (ø)

Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably write out the PCA properly because neighbors does this anyway: #3079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Ingest' object has no attribute '_pca_use_hvg'
2 participants