Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file function to async_impl::multipart #2106

Merged
merged 10 commits into from
Aug 31, 2024

Conversation

NaokiM03
Copy link
Contributor

@NaokiM03 NaokiM03 commented Jan 23, 2024

Related to #646

Add file function to async_impl::multipart::{Form, Part}.

Notes

Since From<File> for Body was added in #1360, I decided to use the stream function that uses it internally.

This comment says the backend did not support chunked requests, but Transfer-Encoding: chunked should be accepted for HTTP/1.1.

@Feriixu
Copy link

Feriixu commented Aug 27, 2024

@NaokiM03 Are you still developing this? I would very much like this feature merged.

@NaokiM03
Copy link
Contributor Author

@Feriixu

No, this pull request is open, not draft. This means that the implementation I envisioned has already been done and is not under development.

At the time I wanted this feature, but unfortunately I got no response. So I don't even know if this code is correct.
It would be better to ask one of the committers than to tell me.

Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to have let this drop! The code looks excellent to me, starting CI, and assuming all is well, I'd be happy to merge.

tests/multipart.rs Outdated Show resolved Hide resolved
@NaokiM03
Copy link
Contributor Author

@NaokiM03
Copy link
Contributor Author

@seanmonstar
Could you approve again?

Fixed an error that was occurring in CI. 350733f
Sorry, I ran all the tests again and found that the doc test was failing, so I fixed it. 24b6270

Sorry to have let this drop!

No problem at all. I understand that you are busy and I appreciate your contribution to the Rust ecosystem because I like Rust.

@seanmonstar seanmonstar merged commit cc3dd51 into seanmonstar:master Aug 31, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants