feat: Expose streaming as public API wrap
#2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
commented
Apr 22, 2024
src/async_impl/body.rs
Outdated
| /// # Optional | ||
| /// | ||
| /// This requires the `stream` feature to be enabled. | ||
| pub fn streaming<B>(inner: B) -> Body |
There was a problem hiding this comment.
I'm not sure if it's ok to keep the naming. I'm open to other candidates. cc @seanmonstar
There was a problem hiding this comment.
Hm, maybe Body::wrap(other)? Since a particular implementation might not actually be streaming?
There was a problem hiding this comment.
DONE. @seanmonstar, please take a look.
Signed-off-by: Xuanwo <[email protected]>
Xuanwo
force-pushed
the
expose-streaming
branch
from
0ac9e48
to
6d1af6a
Compare
|
Hi, @seanmonstar, do you think it's a good time for us to expose this API? |
Xuanwo
changed the title
streaming as public API wrap
Signed-off-by: Xuanwo <[email protected]>
seanmonstar
approved these changes
Sep 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2243