Revert "Add impl Service<http::Request<Body>> for Client"
#2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if tower has just released a 0.5 version, which means that when updating reqwest to it, you'll have to do a breaking changes anyway. So can we add this additional |
|
The |
|
Does gating this behind a feature flag solves the stability/inference issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #2356
This reverts commit 522216e.
There was a report in #2395 that the second impl causes inference problems. While not a semver problem, it now makes me wonder if it's worth having the second impl. It's not hard for anything to have a middleware layer that converts the types.
cc @alekseysidorov