Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump pylint from 3.1.1 to 3.2.2 in the test-and-lint-dependencies group #814

Merged
merged 2 commits into from
May 21, 2024
+6 −2
Merged

build(deps): bump pylint from 3.1.1 to 3.2.2 in the test-and-lint-dependencies group #814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
603b461
---
dependabot[bot] May 20, 2024
f61cf1a
GCPSigner: Add exception for unsupported keys
jku May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements-lint.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
mypy==1.10.0
black==24.4.2
isort==5.13.2
pylint==3.1.1
pylint==3.2.2
bandit==1.7.8
6 changes: 5 additions & 1 deletion securesystemslib/signer/_gcp_signer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,18 @@ def _get_hash_algorithm(public_key: Key) -> str:
if public_key.keytype == "rsa":
# hash algorithm is encoded as last scheme portion
algo = public_key.scheme.split("-")[-1]
if public_key.keytype in [
elif public_key.keytype in [
"ecdsa",
"ecdsa-sha2-nistp256",
"ecdsa-sha2-nistp384",
]:
# nistp256 uses sha-256, nistp384 uses sha-384
bits = public_key.scheme.split("-nistp")[-1]
algo = f"sha{bits}"
else:
raise exceptions.UnsupportedAlgorithmError(
f"Unsupported key type {public_key.keytype} in key {public_key.keyid}"
)
jku marked this conversation as resolved.
Show resolved Hide resolved

# trigger UnsupportedAlgorithm if appropriate
_ = sslib_hash.digest(algo)
Expand Down