Escape file paths #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hmm, I haven't run into this but that seems like an issue. This looks great, let me just do some testing so I understand it and I'll merge. Thanks for sending it over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I store all my images in a folder called
# Pics(so it stays at the top of alphabetic listings). Isolate is not able to display any images within that folder as#is a special character in URLs.This PR escapes all file paths, which fixes the issue for me.
There was no info on contributing guidelines so I'm just sending this off. Please tell me if you want any changes Seena.
Thanks btw, this is a really cool project! (had been thinking of doing something like this, but never actually did it)