Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.0.38 #59

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Rc 1.0.38 #59

merged 2 commits into from
Jun 6, 2024

Conversation

semuadmin
Copy link
Contributor

pynmeagps Pull Request Template

Description

  1. Add Locosys proprietary NMEA GET and SET messages:

    • $PINVCRES: Clear the NVM data
    • $PINVCSTR: Start session
    • $PINVMATTIT: ATTIT information
    • $PINVMIMU: MEMS RAW-DATA message information
    • $PINVMINR: Calibration status
    • $PINVMSTR: Session Status
    • $PINVMSLOPE: SLOPE information
    • $PLSC: Set status/poll version
    • $PLSR: Set status response
    • $PLSVD: Attitude yaw, pitch, roll

    NB: $PMTKnnn: proprietary command message sets not yet implemented

Fixes # (issue)

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Locosys GET and SET streaming tests added

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the enhancement New feature or request label Jun 6, 2024
@semuadmin semuadmin added this to the RC 1.0.38 milestone Jun 6, 2024
@semuadmin semuadmin self-assigned this Jun 6, 2024
@semuadmin semuadmin marked this pull request as draft June 6, 2024 09:38
@semuadmin semuadmin marked this pull request as ready for review June 6, 2024 09:46
@semuadmin semuadmin requested a review from a team June 6, 2024 09:46
@semuadmin semuadmin merged commit 730dbcc into master Jun 6, 2024
5 checks passed
@semuadmin semuadmin deleted the RC-1.0.38 branch June 6, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants