Pomodoro program updated #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepandhaghighi
added
bug
sadrasabouri
requested changes
Feb 12, 2024
| @@ -114,7 +114,7 @@ | |||
| <tr align="center"> | |||
| <td>Pomodoro</td> | |||
| <td><code>pomodoro</code></td> | |||
| <td>02:40:00</td> | |||
| <td>02:10:00</td> | |||
There was a problem hiding this comment.
Shouldn't it be 2:15:00 (4 * (25 + 5) + 15 = 135 minutes)?
There was a problem hiding this comment.
Work + Short-Break + Work + Short-Break + Work + Short-Break + Work + Long-Break
sadrasabouri
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
short-breakprogram duration changed from10 minutesto5 minuteslong-breakprogram duration changed from30 minutesto15 minutespomodoroprogram updatedAny other comments?
Most websites offer a Pomodoro timer that follows the 25-5-15 sequence. We plan to add an "Animedoro" #83 timer in the near future, so it would be better to update the Pomodoro program to the standard version.