Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline-level nf-tests #14

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Add pipeline-level nf-tests #14

merged 3 commits into from
Nov 30, 2023

Conversation

pinin4fjords
Copy link
Member

No description provided.

@@ -0,0 +1,5 @@
pipeline_nf-aggregate:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this file in the workflows/nf_aggregate/ folder instead so everything is self-enclosed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, these tests are referencing the main.nf in the root, so it's a pipeline-level one. I think we should probably have another one in the folder you indicate. At least nf-test docs reference both 'pipeline' and 'workflow' level tests, though I'm not sure what the value of both is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll move as required. Thanks!

@drpatelh drpatelh merged commit c687dbe into main Nov 30, 2023
3 checks passed
@drpatelh drpatelh deleted the workflow_nftest branch December 13, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants