Allow underscores in workspace name regex #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've pulled the regular expression used in the error message displayed on the Seqera Platform when you try to create a workspace using an invalid identifier.
laramiellindsey
approved these changes
Apr 22, 2024
|
Can you update the snapshots? |
|
@maxulysse Snapshots updated. The remaining failures seem to be specific to the CI runner - I get passes when testing on Gitpod. |
|
OK, I'd say that the failing tests seems to be connected to Nextflow version, since the one that fails are |
|
Tests look good. I'll update the changelog and then merge. |
drpatelh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing pattern assumes that all org and workspace identifiers are
a-z(no capital letters, underscores, numbers or dashes).This PR adjusts the pattern to fix the pattern to match the one used by Seqera Platform - identifiers must begin and end with
[a-zA-Z0-9]but can otherwise contain (up to 38 chars of) letters lowercase, letters uppercase, numbers, dashes or underscores ([a-zA-Z0-9]|[-_]).