Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom java truststore support and improved exception handling #49

Merged
merged 12 commits into from
Jul 1, 2024

Conversation

ejseqera
Copy link
Member

  • Adds better exception handling in try/catch for general unexpected runtime exceptions (i.e. NullPointerException, MissingPropertyException) and for HTTP response exceptions specific to calls made by REST client.

  • Adds support for providing custom cacerts if used by Seqera Platform Enterprise instances to be used by REST client in functions.nf and to propagate to tw CLI call in SEQERA_RUN_DUMPS process

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ejseqera ejseqera mentioned this pull request Jun 25, 2024
10 tasks
Copy link
Member

@robsyme robsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks Esha!

modules/local/seqera_runs_dump/functions.nf Show resolved Hide resolved
@FriederikeHanssen
Copy link
Member

I tried running this on my QL2 test-runs by just switching out the revision. I guess the https://cloud.seqera.io/orgs/scidev/workspaces/testing/watch/3qH91IevSxwp0Z Is setting the param java_truststore_path mandatory?

@drpatelh
Copy link
Member

Looks great @ejseqera ! I'll have a play locally to see if I can get the tests passing. Be good to confirm that this works in the real-world too.

@adamrtalbot
Copy link
Contributor

I currently get this in the console but it doesn't fail:

WARN: 
        An error occurred while getting workflow details for workflow 3TQhCnJfQsmVGd in workspace etc/etc:
            ↳ startup failed:
Script_a693abc4d14fb12f673d1f777bff0af8.groovy: 191: Unexpected input: '{' @ line 191, column 9.
   process {
           ^

1 error

        
ERROR ~ Exception: startup failed:
Script_a693abc4d14fb12f673d1f777bff0af8.groovy: 191: Unexpected input: '{' @ line 191, column 9.
   process {
           ^

main.nf Outdated Show resolved Hide resolved
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@drpatelh drpatelh merged commit 9237376 into dev Jul 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants