-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow generating ESM output from npm (non-breaking) #1495
Allow generating ESM output from npm (non-breaking) #1495
Conversation
ee86fae
to
b9867ad
Compare
I am more inclined towards #1494 because it's a smaller change, we can discuss more in details there. |
@vicary I closed the other PR and expanded on the README here. Please let me know if there's anything else you'd like to see, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldenquimby Just a few touch ups.
Let's also give it some time for @j0k3r to comment, please also note that we may have some stuck tests that requires resolution from the repo owner before our next release.
Thank you for the help on this @vicary ! |
We're very interested in this PR being merged because the lack of support for ESM is a blocker for us on several projects. Any chances of that happening soon? |
6d97dd6
to
b45e8bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, can you just squash all commits?
b45e8bd
to
0e373da
Compare
What did you implement:
Closes #1493
How did you implement it:
How can we verify it:
.js
file allowsserverless invoke local
to work, and includingtype: module
allows the deployed Lambda to work:Todos:
Is this ready for review?: YES
Is it a breaking change?: NO