-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fputsx is not round-trip safe with backslash-ending usernames #1055
Comments
I had been looking at that code, and it seemed too brittle, and inconsistent. I preferred to not change it at all while it worked, but your comment seems to be what I was waiting/expecting for: a report that it actually doesn't work. Do you have any specific fix in mind? Should we remove support for line continuations completely? That would keep it simple, by calling standard fgets(3). (But I was worried that it could break existing config files.) |
From what I can tell, line continuation doesn't work on glibc systems for lookup:
Thus I cannot imagine it being used a lot, and wouldn't worry about breaking config files (which were already broken if used).
I was thinking replace fgetsx/fputsx by fgets/fputs. |
Thanks!
Sounds like what I had in mind. I'll have a try. :-) |
It seems they never worked correctly. Let's keep it simple and remove support for escaped newlines. Closes: <shadow-maint#1055> Reported-by: Chris Hofstaedtler <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
It seems they never worked correctly. Let's keep it simple and remove support for escaped newlines. Closes: <shadow-maint#1055> Reported-by: Chris Hofstaedtler <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
On the other hand, user and group names are not allowed to contain a Line 60 in f3f501c
|
I think (As such, the reproducer above doesn't work as-is with upstream shadow. It works without |
What's your opinion? Do you still think fgetsx()/fputsx() are broken? |
Yes. |
I tend to agree; (And they keep the software more complex, which is bad per se.) |
It seems they never worked correctly. Let's keep it simple and remove support for escaped newlines. Closes: <shadow-maint#1055> Reported-by: Chris Hofstaedtler <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
It seems they never worked correctly. Let's keep it simple and remove support for escaped newlines. Closes: <shadow-maint#1055> Reported-by: Chris Hofstaedtler <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
It seems they never worked correctly. Let's keep it simple and remove support for escaped newlines. Closes: <shadow-maint#1055> Reported-by: Chris Hofstaedtler <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
It seems they never worked correctly. Let's keep it simple and remove support for escaped newlines. Closes: <shadow-maint#1055> Reported-by: Chris Hofstaedtler <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
It seems they never worked correctly. Let's keep it simple and remove support for escaped newlines. Closes: <shadow-maint#1055> Reported-by: Chris Hofstaedtler <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
It seems they never worked correctly. Let's keep it simple and remove support for escaped newlines. Closes: <shadow-maint#1055> Reported-by: Chris Hofstaedtler <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076619 reports:
The following sequence breaks /etc/group:
Results in:
Should have been:
I believe this is caused by
fgetsx
"supporting" backslash as line-continuation indicator, butThe text was updated successfully, but these errors were encountered: