Some trivial improvements in strftime(3)-related code #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
%F is specified by ISO C99. It adds semantic meaning as printing an ISO 8601 date. Scripted change: $ cat ~/tmp/spatch/strftime_F.sp @@ @@ - "%Y-%m-%d" + "%F" $ find contrib/ lib* src/ -type f \ | xargs spatch --sp-file ~/tmp/spatch/strftime_F.sp --in-place Signed-off-by: Alejandro Colomar <[email protected]>
If localtime_r(3) fails, just print future, as we do in day_to_str(). It should only fail for unrealistic dates, if at all. Signed-off-by: Alejandro Colomar <[email protected]>
Just like we do in day_to_str(). Signed-off-by: Alejandro Colomar <[email protected]>
strftime(3) is not a variadic function; there's exactly one argument after the format string. Signed-off-by: Alejandro Colomar <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
hallyn
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.