Chain free(strzero(s))

[alejandro-colomar]

This reduces repetition of the argument, which could be error-prone.

We need to return the input pointer from memzero() and strzero() for that.

---

Revisions:

v2

• Also replace freezero(3bsd) by free(memzero()).

$ git range-diff shadow/master gh/strzero strzero 
1:  4985e362 = 1:  4985e362 lib/: Move memzero.[ch] under lib/string/memset/
2:  b027fb9b = 2:  b027fb9b lib/string/memset/: memzero(), strzero(): Return the pointer
3:  9b295a2d = 3:  9b295a2d lib/: Chain free(strzero(s))
-:  -------- > 4:  6e9f2b7b lib/: Use free(memzero()) instead of freezero(3bsd)

v3

• Revert to v1 [@hallyn ]

$ git range-diff shadow/master gh/strzero strzero 
1:  4985e362 = 1:  4985e362 lib/: Move memzero.[ch] under lib/string/memset/
2:  b027fb9b = 2:  b027fb9b lib/string/memset/: memzero(), strzero(): Return the pointer
3:  9b295a2d = 3:  9b295a2d lib/: Chain free(strzero(s))
4:  6e9f2b7b < -:  -------- lib/: Use free(memzero()) instead of freezero(3bsd)

v3b

• Rebase

$ git range-diff master..gh/strzero shadow/master..strzero 
1:  4985e362 = 1:  c049eef9 lib/: Move memzero.[ch] under lib/string/memset/
2:  b027fb9b = 2:  a11b8317 lib/string/memset/: memzero(), strzero(): Return the pointer
3:  9b295a2d = 3:  2dcefb5c lib/: Chain free(strzero(s))

[hallyn]

Can this result in bzero(NULL) being called?

[alejandro-colomar]

Can this result in bzero(NULL) being called?

D'oh! Indeed. Thanks for catching that!