Fix a race condition that could allow same Salt/IV to be reused #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce if timed correctly
xiaokangwang
force-pushed
the
dev-ssivracecond
branch
from
cc36917
to
e07df3f
Compare
|
Thanks for the PR! :) |
xiahaijiao
pushed a commit
to xiahaijiao/go-shadowsocks2
that referenced
this pull request
Jan 10, 2024
Fix a race condition that could allow same Salt/IV to be reused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the attacker have precise timing, it could be possible for it to trick ss into accept multiple connection with the same Salt/IV if they all pass the Salt/iv test at the same time if while other connection c.Encrypter(salt) is in process, and before they add that IV into the anti-replay pool.
This PR does not solve any protocol weakness.