Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed-resources results in bug #20

Closed
Ifitrains opened this issue Apr 8, 2024 · 2 comments · Fixed by #22
Closed

embed-resources results in bug #20

Ifitrains opened this issue Apr 8, 2024 · 2 comments · Fixed by #22

Comments

@Ifitrains
Copy link

Hi,

if you use embed-resources: true, the logo behaves very irrationally:

---
format:
  revealjs:
    slide-number: true
    footer: <https://quarto.org>
    header: Quarto Presentations with beautiful slide decks made by RevealJs
    header-logo: images/Vector-based_example.svg
    embed-resources: true
filters:
  - reveal-header
---

image

@shafayetShafee
Copy link
Owner

Oops, somehow I missed the notification!

Anyway, I can't reproduce the issue with the quarto version 1.4.550 and extension version 1.2.7.

Can you tell me the quarto version that you are using and confirm that you are using the latest version the reveal-header extension? Also the browser information might be useful.

@shafayetShafee
Copy link
Owner

Okay, I think I have found the issue. I was testing embed-resources: true with a png file. But the problem occurs with svg file. Because with embed-resources: true, contents of svg file is written inside of <svg> tag, instead of <img> tag. Thanks for reporting the bug. Let me fix this.

shafayetShafee added a commit that referenced this issue May 10, 2024
@shafayetShafee shafayetShafee linked a pull request May 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants