Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix colors and shapes #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

williamhickman
Copy link

searches/maximum colors and shapes were reversed

searches/maximum colors and shapes were reversed
@shakty
Copy link
Owner

shakty commented Feb 9, 2022

Hi,

Thanks for this pull request! It's a bit difficult to read because the indentation is changed on every line, but the only relevant change is on line 35?

@williamhickman
Copy link
Author

Sorry about that, I copied and pasted a whole section so it's hard to find what I actually changed. It was just a simple fix (not meaningful for results, just for display purposes) on lines 32, 33, and 35. The maximum info point was supposed to be a pink triangle and all other sampled points were supposed to be black dots, but the code (as previously written) had reversed the colors in the legend and in the actual plot.

@williamhickman
Copy link
Author

The only real change was on line 35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants