Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit ...{:type} annotations from search index #2922

Merged
merged 7 commits into from
Jul 20, 2024

Conversation

siefkenj
Copy link

@siefkenj siefkenj commented Jun 7, 2024

Fixes #2913 by omitting the {:type} annotations from the search index when they appear in inline code.

Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: 6787eae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 3:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2024 3:32pm

Copy link

vercel bot commented Jun 7, 2024

@siefkenj is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@siefkenj
Copy link
Author

@dimaMachina Are there any other changes needed on this PR?

@dimaMachina
Copy link
Collaborator

I am currently busy with other tasks, no worries I will include this change in next release when I will back to clean up Nextra for contributions

Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for taking the time to merge this!

@dimaMachina dimaMachina merged commit 3002b01 into shuding:v3 Jul 20, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants