chore: some changes and TODO requests #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DedicatedDev
commented
Sep 18, 2023
DedicatedDev
commented
- optimize code
- added update requests as TODO:
DedicatedDev
requested review from
amityadav0 and
liangping
and removed request for
amityadav0
amityadav0
reviewed
Sep 18, 2023
amityadav0
reviewed
Sep 20, 2023
| @@ -77,11 +78,38 @@ pub fn execute_make_swap( | |||
| )))); | |||
| } | |||
|
|
|||
| // TODO: I guess we have add order here with status - Initial. | |||
| // This optimistic operation will update user's experiences in frontend code. | |||
| // When success update status as a Sync. when failed, we can remove that pool with refund logic. | |||
There was a problem hiding this comment.
I think we don't need to remove it, we can add a status Failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.