Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: efi fat32 compatibility with nvme 4KBn sector size #8156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aarnaud
Copy link
Contributor

@aarnaud aarnaud commented Jan 16, 2024

Pull Request

What? (description)

Fix the compatibility For Advanced Format 4K Native drives (4-KB-per-sector) drives, the minimum size is 260 MB, due to a limitation of the FAT32 file format.

Why? (reasoning)

FAT32 spec :

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

For Advanced Format 4K Native drives (4-KB-per-sector) drives,
the minimum size is 260 MB, due to a limitation of the FAT32 file format

Signed-off-by: Anthony ARNAUD <[email protected]>
@smira
Copy link
Member

smira commented Jan 17, 2024

Thanks for your PR, it does make a lot of sense. We need to consider on our side the effects of changing size of the partition for existing installs (when upgrading). It makes perfect sense for upgrades of course.

@frezbo
Copy link
Member

frezbo commented Jan 21, 2024

Thanks for your PR, it does make a lot of sense. We need to consider on our side the effects of changing size of the partition for existing installs (when upgrading). It makes perfect sense for upgrades of course.

while we move to sd-boot for 1.7 we can maybe make it bigger to accomodate UKI too? 🤔

@smira
Copy link
Member

smira commented Jan 22, 2024

If we move to sd-boot, we have 1 GiB EFI partition there. This change is about GRUB-style partitioning scheme.

Copy link

github-actions bot commented Jun 5, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jun 5, 2024
@aarnaud
Copy link
Contributor Author

aarnaud commented Jun 5, 2024

I don't know if it's still require with 1.7 and sd-boot ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants