Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update deploying cilium docs for v1.8 #9034

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ChickenIQ
Copy link

Pull Request

What? (description)

Replace quay.io/cilium/cilium-cli-ci:latest with alpine/helm:latest and modify the command accordingly in "Method 5: Using a job".

Why? (reasoning)

The current method does not support arm64 as there are no available images for this architecture. This solves that problem and is a drop-in replacement.

Acceptance

Please use the following checklist:
Most of the tasks in this checklist have generated unnecessary commits by removing newlines from existing code, so I decided not to include them.

- install
- cilium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a typo or should it be two times?

I would want some input from @leppeK on this change, as he brought this change initially

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is correct.
helm install [NAME] [CHART] [flags]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For helm it is correct, unfortunately helm leaves traces of the release which you might not want.

I'll see if I can convince Cilium to provide an official container image for all platforms

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comments already indicate that you can use this method to do anything, if you want to use this to install something else using helm or whatever it works as well.

A use case could be installing your CNI and/or ArgoCD at bootstrap time

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it the same as manually installing using helm after bootstrap?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing stuff at bootstrap means you can do it completely declaratively and in one go and at the right time... Great for reproducibilty

@ChickenIQ
Copy link
Author

Added the namespace. Previously it was trying to install to the "default" namespace instead of "kube-system". I somehow managed to not include it in the commit.
Any progress on getting the cilium-cli-ci image built for arm64?

@leppeK
Copy link
Contributor

leppeK commented Aug 12, 2024

I've asked over at Cilium to provide an official image so we'd have to wait for that

@leppeK
Copy link
Contributor

leppeK commented Aug 14, 2024

cilium/cilium-cli#2755

Let's wait for this to be implemented and update the docs accordingly

@leppeK
Copy link
Contributor

leppeK commented Aug 21, 2024

Added the namespace. Previously it was trying to install to the "default" namespace instead of "kube-system". I somehow managed to not include it in the commit. Any progress on getting the cilium-cli-ci image built for arm64?

@ChickenIQ
can you test with https://hub.docker.com/r/leppek/cilium-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants