Add global setting for sent media quality #5781
Conversation
|
Can we get a screenshot of what it looks like? |
ts/views/conversation_view.ts
Outdated
| @@ -547,6 +547,9 @@ export class ConversationView extends window.Backbone.View<ConversationModel> { | |||
| // setupCompositionArea | |||
| window.reduxActions.composer.resetComposer(); | |||
|
|
|||
| window.reduxStore.getState().composer.shouldSendHighQualityAttachments = | |||
There was a problem hiding this comment.
We can't just overwrite state in redux like this.
The global setting state should already live in the items duck so how about we create a selector that derives the state?
There was a problem hiding this comment.
whew, such a relief; this was far too much a hack for my taste, but I was poking around for the fuse in the dark; thanks a bunch for the ducks reference, would have taken me way too long to find it.
Following in the shoes of Android and iOS, this change adds a global setting for defining a preference for standard or high quality media uploads in conversations. This work takes inspiration from the theme and spell check settings that are structurally similar (drop down select) and nearby in the ui (also in Chats), respectively. Some patterns may be incorrect or dated, as these were selected not based on how recently they were added. No new features were added that needed novel testing pathways, we simply wired up an existing boolean with a global default. As such, functionality has been manually verified on a linux, and confirmed to set the global default as desired. Some changes were also made to Preferences.stories.tsx so that it would compile.
urandom2
force-pushed
the
mediaquality
branch
from
6d3df8d
to
6a0b7da
Compare
|
unrelated, this seems like a setting that would be really nice to have live in the user profile alongside |
|
@josh-signal: anything else you need from me, or is this just stuck in the review queue? |
There was a problem hiding this comment.
@arnottcr sorry it took me so long to pull it down and test it. It doesn't seem to be working at the moment because when the REPLACE_ATTACHMENTS action runs it resets the quality to "standard".
I think we'll need 3 different states here (unset, set to standard, set to high) if it's unset we go with whatever your preference is. Feel free to rename the shouldSendHighQualityAttachments property and perhaps use undefined, standard, and high as the states.
|
Sorry for bumping but what's the status on this? I'd love to see this feature implemented. |
|
I gave it a "college try", but as a not frontend dev, this quickly became out of my depth, and I think the core team should probably take the lead on such a refactor. If somebody wants to take over the work, I am happy to handoff. |
|
@arnottcr I can take it to the finish line sometime soon. Thanks for the initial work! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
yeah, I do not have the bandwidth or background to drive this forward; I am sad to see this feature gap between mobile and desktop, but it is understandable with the signal team size; hope this gets resolved eventually! |
|
FYI we merged this in main: 1109415 |
First time contributor checklist:
Contributor checklist:
developmentbranchyarn readyrun passes successfully (more about tests here)Description
Following in the shoes of Android and iOS, this change adds a global
setting for defining a preference for standard or high quality media
uploads in conversations.
This work takes inspiration from the theme and spell check settings that
are structurally similar (drop down select) and nearby in the ui (also
in Chats), respectively. Some patterns may be incorrect or dated, as
these were selected not based on how recently they were added.
No new features were added that needed novel testing pathways, we simply
wired up an existing boolean with a global default. As such,
functionality has been manually verified on a linux, and confirmed to
set the global default as desired. Some changes were also made to
Preferences.stories.tsx so that it would compile.
Screenshot
Not much to see here, as it still looks the same, but you can now get high quality by default:
Definitely went the easy route and simply added a new element, without a new section or description text; also the alignment with the checkboxes means it may not look super pretty, but it does what it needs to:
