-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an official badge to the Note To Self channel #6278
Conversation
I have slightly adjusted the badge to make it fit better. I have also manually checked that the element is displayed correctly at all zoom levels. |
fd3f510
to
8a3c41e
Compare
8a3c41e
to
a737a73
Compare
I cleaned up the commits and rebased to v6.9.0. |
Thank you for opening this PR, it will be released soon |
did a UI/UX expert review these changes before they went into production? the idea of protecting users from UI confusion is definitely a good one. until now, you could have kept the Signal app window visible on the screen (think of a large 4K display) and worked in another app. by choosing the "verified" badge to be the same color as the unread message indicator, along with the location of that badge, the user is "tricked" into thinking they have unread messages every time their eyes glance over to the Signal app, i ask you to improve this generally good idea by making the following changes (either one, or preferably both):
best regards |
I actually searched for posts about people not approving of this change. Especially for people with visual impairments the icons look just the same: Blue circle like object with some grey number or checkmark in it. The slight offset doesn't help because peripheral vision in humans just detects the presence and not the exact location. It certainly is a nice change if there was an option to rename the trusted contact and change or replace the icon along with it. Since I control the names of the contacts on my device there is little reason to worry anyway I use a wrong contact for "Note to self". @4elta |
Hey (disclaimer, I do not work for Signal or know anyone there, I did this PR on my free time), I suggested this change because this is how Signal Android has it currently for months now. I'm sorry if you disagree with this design. However I agree that there could be other ways to make it look less confusing. On desktop the notification circle looks quite similar to the badge, this might not be as much of a problem on Android.
I personally like this idea, unfortunately any design change like this one would have to be approved by the Signal team, which I can't help you with. I saw you opened an issue, hopefully things improve for everyone. Have a nice day |
thank you @hackerbirds for your reply and especially for your work.
this made me think, because you (@spacesynth) are absolutely right. so this morning i decided to try something i have stumbled upon while researching how other messengers provide the "notes to self" functionality:
this is how i would have always preferred it 😎 best regards |
@4elta |
First time contributor checklist:
Contributor checklist:
main
branchyarn ready
run passes successfully (more about tests here)Description
This PR adds an official badge to the "Note to Self" channel, as done on Android.
Without this badge, it is possible for a user to rename themselves "Note to Self", change their profile picture, and become indistinguishable with the legitimate channel. This is an issue, and I believe that it should be fixed on all platforms. Adding a badge helps users know which one is the real one.
This design change should also be helpful to those who rely on this channel a lot, because it makes it easier to see.
Screenshots