Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the common name field from the certs. #102

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

dlorenc
Copy link
Member

@dlorenc dlorenc commented May 22, 2021

This was overkill and the field is deprecated anyway. We only check the SAN.

Signed-off-by: Dan Lorenc [email protected]

This was overkill and the field is deprecated anyway. We only check the SAN.

Signed-off-by: Dan Lorenc <[email protected]>
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine; we still need to solve #44

@dlorenc dlorenc merged commit aa32c93 into sigstore:main May 24, 2021
@dlorenc dlorenc deleted the cn branch May 24, 2021 17:06
@cpanato cpanato added this to the 0.1.0 milestone Jun 8, 2021
tommyd450 pushed a commit to tommyd450/fulcio that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants