Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement modular CA and SoftHSM integration #115

Merged
merged 65 commits into from
Jul 2, 2021
Merged

Implement modular CA and SoftHSM integration #115

merged 65 commits into from
Jul 2, 2021

Conversation

lukehinds
Copy link
Member

@lukehinds lukehinds commented Jun 8, 2021 •
edited
Loading

Signed-off-by: Luke Hinds [email protected]

Luke Hinds added 16 commits June 8, 2021 15:47
[WIP] Implement modular CA and SoftHSM integration
50c124f 
Signed-off-by: Luke Hinds <[email protected]>
Fix config path
213b6a5 
Signed-off-by: Luke Hinds <[email protected]>
Serial num handling and other refactors
2e3bff8 
Signed-off-by: Luke Hinds <[email protected]>
Fix flags and output cert to file option
4638aff 
Signed-off-by: Luke Hinds <[email protected]>
Further improvements
554f320 
Signed-off-by: Luke Hinds <[email protected]>
Merge from main
86a0b57 
Signed-off-by: Luke Hinds <[email protected]>
SoftHSM warning
100747d 
Signed-off-by: Luke Hinds <[email protected]>
Fix up readme
b30a497 
Signed-off-by: Luke Hinds <[email protected]>
Fix up readme
9f271e5 
Signed-off-by: Luke Hinds <[email protected]>
EOL whitespace
32fe750 
Signed-off-by: Luke Hinds <[email protected]>
Formatting fixes
0cd7213 
Signed-off-by: Luke Hinds <[email protected]>
Formatting fixes
2c71008 
Signed-off-by: Luke Hinds <[email protected]>
Gen random serial for Root CA
870a914 
Signed-off-by: Luke Hinds <[email protected]>
createca code cleanuo
c74f39c 
Signed-off-by: Luke Hinds <[email protected]>
More refactoring
3afe7a3 
Signed-off-by: Luke Hinds <[email protected]>
Fix Lint errors
b84f201 
Signed-off-by: Luke Hinds <[email protected]>
@lukehinds lukehinds marked this pull request as ready for review June 9, 2021 13:23
@lukehinds lukehinds changed the title [WIP] Implement modular CA and SoftHSM integration Implement modular CA and SoftHSM integration Jun 9, 2021
bobcallaway
bobcallaway reviewed Jun 10, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
cmd/app/createca.go Outdated Show resolved Hide resolved
cmd/app/createca.go Outdated Show resolved Hide resolved
cmd/app/createca.go Outdated Show resolved Hide resolved
pkg/api/fulcioca_signing_cert.go Outdated Show resolved Hide resolved
pkg/api/fulcioca_signing_cert.go Outdated Show resolved Hide resolved
pkg/ca/fulcioca/fulcioca.go Outdated Show resolved Hide resolved
pkg/generated/restapi/configure_fulcio_server.go Outdated Show resolved Hide resolved
pkg/generated/restapi/configure_fulcio_server.go Outdated Show resolved Hide resolved
Bob's review points
ea83614 
Signed-off-by: Luke Hinds <[email protected]>
@lukehinds
Copy link
Member Author

lukehinds commented Jun 11, 2021 •
edited
Loading

@bobcallaway , solid review thanks. Everything above is addressed, apart from spiffe/spire which I need to look into a little more (still unsure we can support this). I will tag you when that is pushed.

Luke Hinds added 4 commits June 11, 2021 08:24
Merge changes from main
d1d1da4 
Signed-off-by: Luke Hinds <[email protected]>
gofmt nits
1cd9e8c 
Signed-off-by: Luke Hinds <[email protected]>
Further review changes
ee022de 
Signed-off-by: Luke Hinds <[email protected]>
Revert to no email verify conditional
0341df1 
Signed-off-by: Luke Hinds <[email protected]>
bobcallaway
bobcallaway reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple other small comments

cmd/app/createca.go Outdated Show resolved Hide resolved
cmd/app/createca.go Outdated Show resolved Hide resolved
TEST CI
d4ad4f4 
Signed-off-by: Luke Hinds <[email protected]>
@cpanato cpanato mentioned this pull request Jun 30, 2021
Merged
Luke Hinds added 3 commits July 1, 2021 08:03
CI fixes from carlos
f899496 
Signed-off-by: Luke Hinds <[email protected]>
Re-add CGO
336c998 
Signed-off-by: Luke Hinds <[email protected]>
Rebase
5a507f4 
Signed-off-by: Luke Hinds <[email protected]>
cpanato
cpanato reviewed Jul 1, 2021
View reviewed changes
config/deployment.yaml Outdated Show resolved Hide resolved
cpanato
cpanato reviewed Jul 1, 2021
View reviewed changes
config/deployment.yaml Outdated Show resolved Hide resolved
Luke Hinds added 3 commits July 1, 2021 10:48
Amend fulcio serve line
f23a897 
Signed-off-by: Luke Hinds <[email protected]>
Remove CGO_ENABLED
6848dec 
Signed-off-by: Luke Hinds <[email protected]>
Remove CGO_ENABLED
514bac0 
Signed-off-by: Luke Hinds <[email protected]>
@cpanato cpanato added this to the 0.1.0 milestone Jul 1, 2021
bobcallaway
bobcallaway reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small nits but overall looking good

pkg/api/ca.go Outdated Show resolved Hide resolved
pkg/api/googleca_signing_cert.go Outdated Show resolved Hide resolved
pkg/api/fulcioca_signing_cert.go Outdated Show resolved Hide resolved
pkg/api/ca.go Outdated Show resolved Hide resolved
pkg/api/ca.go Outdated Show resolved Hide resolved
pkg/api/fulcioca_signing_cert.go Outdated Show resolved Hide resolved
pkg/ca/fulcioca/fulcioca.go Outdated Show resolved Hide resolved
pkg/ca/fulcioca/fulcioca.go Outdated Show resolved Hide resolved
pkg/challenges/challenges.go Show resolved Hide resolved
lukehinds and others added 10 commits July 1, 2021 12:38
@lukehinds @bobcallaway
Update pkg/api/googleca_signing_cert.go
eb9e80c 
Co-authored-by: Bob Callaway <[email protected]>
@lukehinds @bobcallaway
Update pkg/api/fulcioca_signing_cert.go
88694a7 
Co-authored-by: Bob Callaway <[email protected]>
@lukehinds @bobcallaway
Update pkg/api/ca.go
e514571 
Co-authored-by: Bob Callaway <[email protected]>
@lukehinds @bobcallaway
Update pkg/ca/fulcioca/fulcioca.go
9f3fc4f 
Co-authored-by: Bob Callaway <[email protected]>
@lukehinds @bobcallaway
Update pkg/ca/fulcioca/fulcioca.go
d7f5db6 
Co-authored-by: Bob Callaway <[email protected]>
@lukehinds @bobcallaway
Update pkg/api/fulcioca_signing_cert.go
1240c07 
Co-authored-by: Bob Callaway <[email protected]>
@lukehinds @bobcallaway
Update pkg/api/ca.go
445e111 
Co-authored-by: Bob Callaway <[email protected]>
Use generic error
bc04c01 
Signed-off-by: Luke Hinds <[email protected]>
Merge branch 'modular-ca' of github.com:lukehinds/fulcio into modular-ca
852345b
Lint fixes
be0ae46 
Signed-off-by: Luke Hinds <[email protected]>
lukehinds
lukehinds commented Jul 1, 2021
View reviewed changes
config/deployment.yaml Outdated Show resolved Hide resolved
@lukehinds lukehinds merged commit 78cbe2d into sigstore:main Jul 2, 2021
@lukehinds lukehinds deleted the modular-ca branch July 2, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@bobcallaway bobcallaway bobcallaway approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukehinds @bobcallaway @cpanato