gitlab: remove build config URI. #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was erroneously set to match the build signer URI. This will eventually be pipeline_ref when it is populated (dependent on https://gitlab.com/gitlab-org/gitlab/-/merge_requests/121597) Signed-off-by: Billy Lynch <[email protected]>
priyawadhwa
approved these changes
May 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
+ Coverage 56.02% 56.18% +0.15%
==========================================
Files 50 50
Lines 2904 2903 -1
==========================================
+ Hits 1627 1631 +4
+ Misses 1133 1129 -4
+ Partials 144 143 -1
|
haydentherapper
approved these changes
May 24, 2023
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was erroneously set to match the build signer URI. This will eventually be pipeline_ref when it is populated (dependent on https://gitlab.com/gitlab-org/gitlab/-/merge_requests/121597)
Release Note
BREAKING CHANGE: GitLab Build Config URI claim is temporarily removed. This was erroneously set to an incorrect value that did not match the documentation. This will repopulated once the correct value is available in upstream claims.
Documentation