-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fulcio-server: add html page when humans reach the server via the browser #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wser Signed-off-by: Carlos Panato <[email protected]>
cpanato
commented
Jul 14, 2021
bobcallaway
reviewed
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't touch the openapi file at all for this; we can handle it by declaring the middleware handler directly for the "/" path.
79ab953
to
9a5ad81
Compare
Signed-off-by: Carlos Panato <[email protected]>
thanks @bobcallaway for your review and insights! really appreciate |
Signed-off-by: Carlos Panato <[email protected]>
dlorenc
approved these changes
Jul 20, 2021
LGTM now, I'll wait for Bob. |
bobcallaway
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we access via browser the Fulcio server (for example) https://fulcio.sigstore.dev/ it returns
maybe is good to add a webpage and say something :) instead of return a json 404.
This PR adds a very simple homepage when humans access that page
if we don't want that and this is by design feel free to close this PR