Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fulcio-server: add html page when humans reach the server via the browser #145

Merged
merged 3 commits into from
Jul 20, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 14, 2021

When we access via browser the Fulcio server (for example) https://fulcio.sigstore.dev/ it returns

{
  "code": 404,
  "message": "path / was not found"
}

maybe is good to add a webpage and say something :) instead of return a json 404.

This PR adds a very simple homepage when humans access that page

Screenshot 2021-07-14 at 17 32 01

if we don't want that and this is by design feel free to close this PR

openapi.yaml Outdated Show resolved Hide resolved
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't touch the openapi file at all for this; we can handle it by declaring the middleware handler directly for the "/" path.

docker-compose.yml Outdated Show resolved Hide resolved
pkg/api/homepage.go Outdated Show resolved Hide resolved
pkg/generated/restapi/configure_fulcio_server.go Outdated Show resolved Hide resolved
@cpanato cpanato force-pushed the homepage branch 3 times, most recently from 79ab953 to 9a5ad81 Compare July 20, 2021 11:46
Signed-off-by: Carlos Panato <[email protected]>
@cpanato
Copy link
Member Author

cpanato commented Jul 20, 2021

thanks @bobcallaway for your review and insights! really appreciate
PTAL

Signed-off-by: Carlos Panato <[email protected]>
@dlorenc
Copy link
Member

dlorenc commented Jul 20, 2021

LGTM now, I'll wait for Bob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants