Validate its a recognised CA #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2021 21:10
I had a typo in fuclio serve -ca flag and spent hours trying to work out why the CA backend was failing. The mispelt flag was being captured in the middleware handler instead (ca.go line 65). This will capture it before the server even starts and make it a lot easier to see its just a simple typo. Signed-off-by: Luke Hinds <[email protected]>
Signed-off-by: Luke Hinds <[email protected]>
dlorenc
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a typo in fuclio serve -ca flag and spent hours trying to work
out why the CA backend was failing. The mispelt flag was being
captured in the middleware handler instead (ca.go line 65) with the
genericCAErrorfrom errors.go.This will capture it before the server even starts and make it a
lot easier to see it's just a simple typo.
Signed-off-by: Luke Hinds [email protected]