Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change or to and for known CA types #147

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Conversation

runyontr
Copy link
Contributor

Signed-off-by: Thomas Runyon [email protected]

Before the change the logic would fail:

go run main.go serve --ca googleca --gcp_private_ca_parent=projects/runyontr/locations/us-east1/ca/fulcio
2021-07-19T15:44:31.130-0400    INFO    app/serve.go:41 booya
2021-07-19T15:44:31.130-0400    FATAL   app/serve.go:42 unknown CA: googleca
github.com/sigstore/fulcio/cmd/app.glob..func2
        /Users/tom/go/src/github.com/runyontr/platform-one/big-bang/scratch/sigstore/fulcio/cmd/app/serve.go:42
github.com/spf13/cobra.(*Command).execute
        /Users/tom/go/pkg/mod/github.com/spf13/[email protected]/command.go:860
github.com/spf13/cobra.(*Command).ExecuteC
        /Users/tom/go/pkg/mod/github.com/spf13/[email protected]/command.go:974
github.com/spf13/cobra.(*Command).Execute
        /Users/tom/go/pkg/mod/github.com/spf13/[email protected]/command.go:902
github.com/sigstore/fulcio/cmd/app.Execute
        /Users/tom/go/src/github.com/runyontr/platform-one/big-bang/scratch/sigstore/fulcio/cmd/app/root.go:41
main.main
        /Users/tom/go/src/github.com/runyontr/platform-one/big-bang/scratch/sigstore/fulcio/main.go:21
runtime.main
        /usr/local/Cellar/go/1.16/libexec/src/runtime/proc.go:225
exit status 1

And now it starts up as expected:

❯ go run main.go serve --ca googleca --gcp_private_ca_parent=projects/leapfrogai/locations/us-east1/caPools/fulcio
2021-07-19T15:44:57.994-0400    INFO    config/config.go:78     No config at /etc/fulcio-config/config.json, using defaults: {map[https://accounts.google.com:{https://accounts.google.com sigstore email} https://oauth2.sigstore.dev/auth:{https://oauth2.sigstore.dev/auth sigstore email}]}
2021-07-19T15:44:58.374-0400    INFO    restapi/server.go:231   Serving fulcio server at http://127.0.0.1:51090
^C2021-07-19T15:45:05.940-0400  INFO    restapi/server.go:231   Shutting down... 
2021-07-19T15:45:05.940-0400    INFO    restapi/server.go:231   Stopped serving fulcio server at http://127.0.0.1:51090

@dlorenc dlorenc merged commit 3e63bfb into sigstore:main Jul 19, 2021
@cpanato cpanato modified the milestones: 0.2.0, 0.1.1 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants