Amend HSM cert usage #151
Merged
Amend HSM cert usage #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue with invalid key types when verifying cosign signed registry sigs with a fulcio cert generated using the fuclio createca command This PR makes the resulting createca generated cert have partity to GCA generated certs The result is a HSM / createca root cert can be used to both sign and verify registry entries Resolves: sigstore#150 Signed-off-by: Luke Hinds <[email protected]>
cpanato
reviewed
Jul 26, 2021
| KeyUsage: x509.KeyUsageDigitalSignature | x509.KeyUsageCertSign, | ||
| BasicConstraintsValid: true, | ||
| KeyUsage: x509.KeyUsageCertSign | x509.KeyUsageCRLSign, | ||
| BasicConstraintsValid: true, MaxPathLen: 1, |
There was a problem hiding this comment.
nit: maybe to make it clear put the MaxPathLen: 1, in a new line
There was a problem hiding this comment.
I am not so sure about that, they sit within the same Basic Constraints key
dlorenc
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with invalid key types when verifying
cosign signed registry sigs with a fulcio cert generated using
the fuclio createca command
This PR makes the resulting createca generated cert have partity
to GCA generated certs
The result is a HSM / createca root cert can be used to both sign
and verify registry entries
Resolves: #150
Signed-off-by: Luke Hinds [email protected]