-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile: add rule to download and set swagger and make rule to build the dist #154
Conversation
cpanato
commented
Jul 28, 2021
- Adding the changes we applied for rekor in this PR: makefile: add rule to download and set swagger and make rule to build rekor-cli for cross platform rekor#391
looks fine, two thoughts:
|
thanks for the review |
They might, but since go-swagger is a big part of our code base I want to make sure we're at least notified when an upgrade is released so we can evaluate it. This can be a separate PR but just wanted to capture the idea
|
c8b8dd3
to
6d1547c
Compare
yep, will take a look in the dependabot review and see what we can do, otherwise we can make an action workflow to check that and notify us :)
|
after discussing with @bobcallaway i will update this PR to use something similar we have in https://github.com/kubernetes-sigs/cluster-api/blob/master/hack/tools/go.mod |
6d1547c
to
de2ad8c
Compare
de2ad8c
to
72aa186
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
… the dist Signed-off-by: Carlos Panato <[email protected]>
72aa186
to
06d5fc7
Compare