Add issuer information to code signing certificates #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great work! |
lukehinds
approved these changes
Oct 15, 2021
mattmoor
reviewed
Oct 24, 2021
| Type: IssuerTypeEmail, | ||
| IssuerURL: "https://oauth2.sigstore.dev/auth", | ||
| ClientID: "sigstore", | ||
| IssuerClaim: "$.federated_claims.connector_id", |
There was a problem hiding this comment.
I'm wondering whether it makes sense to have the hard-coded DefaultConfig assume DEX?
This extracts a claim from the OIDC token (defaults to `iss`) and inserts it into the final code signing certificate issued by Fulcio. This provides an explicit link between the identity (i.e. the email or the URI that is the subject of the certificate) to the identity provider who is vouching for an entity holding valid credentials for said identity. The value is stored in an X509 extension with OID: 1.3.6.1.4.1.57264.1.1 Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
bobcallaway
force-pushed
the
add_issuer
branch
from
1e7d17f
to
37fe45a
Compare
Signed-off-by: Bob Callaway <[email protected]>
mattmoor
added a commit
to mattmoor/fulcio
that referenced
this pull request
Oct 25, 2021
This switches from using URIs to using the extensions that Bob is using in sigstore#204 Signed-off-by: Matt Moore <[email protected]>
Closed
bobcallaway
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts a claim from the OIDC token (defaults to
iss) and inserts it into the final code signing certificate issued by Fulcio in an X509 extension.This provides an explicit link between the identity (i.e. the email or the URI that is the subject of the certificate) to the identity provider who is vouching for an entity holding valid credentials for said identity.
The value is stored in an X509 extension with OID:
1.3.6.1.4.1.57264.1.1
WIP due to dexidp/dex#2289
Signed-off-by: Bob Callaway [email protected]