Add support for "meta issuers". #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
force-pushed
the
meta-urls
branch
2 times, most recently
from
a37daec
to
04aeea7
Compare
These are separate from the fixed OIDC issuers, and they represent templates for *classes* of OIDC endpoints that we want to support, e.g. for EKS: ``` https://oidc.eks.*.amazonaws.com/id/* ``` The `*` character here will be used to match `[a-zA-Z0-9_-]+`, so no host or path delimiting characters are allowed to prevent attacks like: ``` https://oidc.eks.mattmoor.io/pwned.amazonaws.com/id/does-not-matter ``` We do NOT maintain OIDC verifiers for all of the possible endpoints, but we do keep an LRU cache to avoid the expensive discovery process on each request. Related: sigstore#212 Signed-off-by: Matt Moore <[email protected]>
mattmoor
changed the title
dlorenc
approved these changes
Oct 28, 2021
|
Let's hold this for @bobcallaway to take a look too, but I like it. |
|
I wanna get this fix in, and then I'll rebase this: #224 |
|
I'm thinking about even making the config use |
bobcallaway
approved these changes
Oct 28, 2021
| } | ||
|
|
||
| // Look in the LRU cache for a verifier | ||
| untyped, ok := fc.lru.Get(issuerURL) |
There was a problem hiding this comment.
I think we're covered by the OIDC lib in case the keys rotate; just noting this in case for some reason it doesn't.
There was a problem hiding this comment.
I believe the OIDC lib internally handles caching/rotating for a particular discovery endpoint, but since each of these "meta" things are N endpoints (where N is possibly O(XXX,XXX)!) I wanted some sort of eviction strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are separate from the fixed OIDC issuers, and they represent templates for classes of OIDC endpoints that we want to support, e.g. for EKS:
The
*character here will be used to match[a-zA-Z0-9_-]+, so no host or path delimiting characters are allowed to prevent attacks like:We do NOT maintain OIDC verifiers for all of the possible endpoints, but we do keep an LRU cache to avoid the expensive discovery process on each request.
Related: #212
Signed-off-by: Matt Moore [email protected]
WIP until #222 lands, and I may add the GKE/EKS stuff to this change.
Release Note