Thread FulcioConfig
through from main via ctx
#249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread
FulcioConfig
through to handlers viactx
based on a value that's explicitlyLoad()
ed at application start. This is the first of what I expect will be a bunch of refactoring PRs for Fulcio, but I'm trying to take them in bite-sized chunks. This change:ctx
as a way we can pass configuration downstream to handlers (here withFulcioConfig
, but I'd like to kill the usage ofviper
in our library code)FulcioConfig
(and eventually others!) periodically (or even via an informer!) to avoid needing to cycle pods to force config reloads.There are some other auxiliary benefits to passing
ctx
like enabling us to model the K8s lifecycle properly by "draining" pods onSIGTERM
, which I'm not sure we properly handle today (would require us to switch to something likeknative.dev/pkg/signals.NewContext
).Signed-off-by: Matt Moore [email protected]
Release Note