-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: This adds example code on how to fetch a fulcio certificate #324
Conversation
This is really cool! Do you think we could toss a small readme next to it explaining the overall usage? |
We could have a |
that is perfect! |
Good idea, I think with a README.md alongside the code works well too. |
After a little discussion on slack last week I was contemplating just moving this pull-request to the https://github.com/sigstore/examples project. It seems fairly unmaintained at the moment and we could probably have project monitors along with code examples for utilizing sigstore/fulcio/rekor there. If that requires a bit more planning I'll just finish up this PR and get it ready for a merge. |
I'd vote to merge this here and then move later if desired. |
echo what bob says, I think we should remove sigstore/examples to be honest. for me it makes sense to have relevant examples under each respective project. |
dce6316
to
297a13e
Compare
Sorry for the delay! Added the license header and wrote a README. If it's a bit on the spare side we can iterate on it now or expand on it later when we get more examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now, just CI has a dep breakage, a quick rebase might resolve that.
297a13e
to
09e813a
Compare
Any reason this was never merged? |
The build looks broken: https://github.com/sigstore/fulcio/runs/5066358179?check_suite_focus=true It might just need a rebase and go mod tidy |
09e813a
to
b6dcb36
Compare
Weird! Rebased and updated the example to account for the new redirect variable that was added. |
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 43.57% 43.57%
=======================================
Files 18 18
Lines 1221 1221
=======================================
Hits 532 532
Misses 615 615
Partials 74 74 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've deprecated the v1 endpoint so would be good to remove that but otherwise LGTM
Signed-off-by: Morten Linderud <[email protected]>
Signed-off-by: Morten Linderud <[email protected]>
Signed-off-by: Morten Linderud <[email protected]>
Signed-off-by: Morten Linderud <[email protected]>
b6dcb36
to
7ec9157
Compare
Patched, rebased and pushed :) |
Summary
The API isn't super clearly documented and the workflow how to fetch certificates is not well explained. There are no simple code examples nor examples around that makes fulcio easy to pick up. This is a start at providing examples for how to utilize fulcio and something we should look at adopting for the other sigstore projects as well.
Signed-off-by: Morten Linderud [email protected]